feat: Add minimum affinity option to locales resolver#28
Merged
ericfjosne merged 4 commits intoMay 20, 2026
Conversation
ericfjosne
changed the title
Collaborator
Author
|
For now, I made 2 changes to the PR:
|
PlaybackSwede
approved these changes
May 20, 2026
ericfjosne
deleted the
feat-Add-requiredAffinity-option-to-LocalesResolver
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are hitting an issue with the current setup, where the default behavior for the ICU
LocaleMatcherpromotes locales which are too distant from what we consider as an acceptable best match.Examples:
nbis promoted as best matching locale for Danishda.idgets promoted as best matching locale for Malayms.rugets promoted as best matching locale for Kazakhkkand Mongolianmn.We would like to enable some level of control over the matching logic. We suggest adding a new
minimumLocaleAffinityconfiguration option, which builds on the locale affinity logic implemented previously.In order to not break existing integrations, we need to set a default value for this new configuration option. We decided to set it to
MUTUALLY_INTELLIGIBLEdefine over here.